Skip to content

fix(kernel): honor use_cloud_fetch - #917

Closed
vuanhphung wants to merge 1 commit into
mainfrom
vu-phung/pecoblr-4134-kernel-cloudfetch
Closed

fix(kernel): honor use_cloud_fetch#917
vuanhphung wants to merge 1 commit into
mainfrom
vu-phung/pecoblr-4134-kernel-cloudfetch

Conversation

@vuanhphung

@vuanhphung vuanhphung commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

What type of PR is this?

  • Bug Fix

Description

Forward the connector's use_cloud_fetch option into the kernel backend. The kernel consumes it as cloudfetch_enabled and selects inline SEA results when disabled.

How is this tested?

  • Unit tests

Focused kernel client and session suites: 155 passed, 1 skipped.

Related Tickets & Documents

PECOBLR-4134


This PR was created with GitHub MCP.

@peco-review-bot peco-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No issues identified by the review bot.

@vuanhphung
vuanhphung force-pushed the vu-phung/pecoblr-4134-kernel-cloudfetch branch from 37bc5f0 to b0643b3 Compare August 18, 2026 06:35
@vuanhphung vuanhphung added the kernel-e2e Trigger preview run of the Kernel E2E workflow on this PR label Aug 18, 2026

@peco-review-bot peco-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: 1 Low

Looks good — a focused, correct fix that forwards use_cloud_fetch into the kernel as the cloudfetch_enabled session conf, with consistent True defaults across session.py, client.py, and the kernel client, and solid unit + e2e coverage. One low-severity note on truthy-string coercion (already matching existing connector behavior).

Comment thread src/databricks/sql/backend/kernel/client.py
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
@vuanhphung
vuanhphung force-pushed the vu-phung/pecoblr-4134-kernel-cloudfetch branch from b0643b3 to 1dd601e Compare August 18, 2026 06:39
@github-actions github-actions Bot removed the kernel-e2e Trigger preview run of the Kernel E2E workflow on this PR label Aug 18, 2026
@vuanhphung vuanhphung added the kernel-e2e Trigger preview run of the Kernel E2E workflow on this PR label Aug 18, 2026

@peco-review-bot peco-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No issues identified by the review bot.

@eric-wang-1990

Copy link
Copy Markdown
Contributor

I do not think Kernel supports disable cloud fetch feature.

@vuanhphung vuanhphung closed this Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-assisted kernel-e2e Trigger preview run of the Kernel E2E workflow on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants