fix(kernel): honor use_cloud_fetch - #917
Closed
vuanhphung wants to merge 1 commit into
Closed
Conversation
vuanhphung
force-pushed
the
vu-phung/pecoblr-4134-kernel-cloudfetch
branch
from
August 18, 2026 06:35
37bc5f0 to
b0643b3
Compare
There was a problem hiding this comment.
Verdict: 1 Low
Looks good — a focused, correct fix that forwards use_cloud_fetch into the kernel as the cloudfetch_enabled session conf, with consistent True defaults across session.py, client.py, and the kernel client, and solid unit + e2e coverage. One low-severity note on truthy-string coercion (already matching existing connector behavior).
Signed-off-by: Vu Anh Phung <vu.phung@databricks.com>
vuanhphung
force-pushed
the
vu-phung/pecoblr-4134-kernel-cloudfetch
branch
from
August 18, 2026 06:39
b0643b3 to
1dd601e
Compare
vuanhphung
had a problem deploying
to
azure-prod
August 18, 2026 06:41 — with
GitHub Actions
Failure
Contributor
|
I do not think Kernel supports disable cloud fetch feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Forward the connector's
use_cloud_fetchoption into the kernel backend. The kernel consumes it ascloudfetch_enabledand selects inline SEA results when disabled.How is this tested?
Focused kernel client and session suites: 155 passed, 1 skipped.
Related Tickets & Documents
PECOBLR-4134
This PR was created with GitHub MCP.